iexplorer: fix livecheck #198238
iexplorer: fix livecheck #198238
Conversation
|
The response format seems to be inconsistent. It's alternating between plain text and XML. |
Co-authored-by: Klaus Hipp <[email protected]>
eleanordoesntcode
force-pushed
the
patch-1
branch
from
53c03b9 to
2cd110d
Compare
|
In either case, the regex here with this strategy works, whereas the previous one only worked when the server returned XML. |
|
Is this software still functional? The appcast has not been updated since 2022 and is 2 major iOS versions behind current. It also appears to rely on iTunes, according to the website. |
|
I'll try it on my machine, 1 second |
|
App seems to be working fine, I tested it with my iPhone SE on the latest iOS version and it worked mostly fine - I wasn't able to access the music but I'm assuming that's due to the fact my iCloud account isn't on my computer and therefore cannot decrypt the songs. |
|
Thanks @eleanordoesntcode. If the regex works I am fine with it, we can't fix upstream returning two different formats. I'll tag @samford for their thoughts. |
There was a problem hiding this comment.
I'm also seeing this switch back and forth between plain text and the Sparkle XML, so this approach makes sense to me (as it currently works for either format). There's only one dmg URL in the plain text changelog, so it may break in the future if upstream doesn't continue to include a URL in the text for the newest version. This is the best we can do for now, though.
For what it's worth, using a header like Accept: application/xml (or Accept: application/rss+xml) doesn't make a difference to this server (i.e., it will still randomly return plain text or XML). [For my own future reference, the MIME types for these responses are text/plain and application/xml.]
| @@ -8,13 +8,13 @@ | |||
| homepage "https://macroplant.com/iexplorer" | |||
|
|
|||
| livecheck do | |||
There was a problem hiding this comment.
| livecheck do | |
| # The response format of this URL seems to randomly switch between a plain | |
| # text changelog and a Sparkle appcast XML file. This matches the version | |
| # from dmg URLs in the text, which should work in either format. | |
| livecheck do |
We should leave an explanatory comment here, as someone may try to switch this back to the Sparkle strategy otherwise.
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
<cask>is the token of the cask you're submitting.After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>is error-free.brew style --fix <cask>reports no offenses.Page is not a classic sparkle update file and so the livecheck failed there.